-
Notifications
You must be signed in to change notification settings - Fork 719
Pipeline to facilitate Roslyn Copilot publish #8508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
trigger: none | ||
pr: none | ||
|
||
resources: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of a meta question here. Should this pipeline even be in this repo? Would conversations be a better place?
For example if you want to change the folder name where it finds the conversations build artifacts to upload. Now you have to make the change across two repos. If this was in conversations you just updated both at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, my thinking was having this closer to the component that actually needs it. The conversations repo has a slightly different set of processes tied to build and release pipelines which are tied to VS. Having it here gives us the freedom to iterate on this quicker. It also keeps this in our teams cross hairs a little more working with the processes we have - its been hard figuring out where things exist, so trying to keep some of the infra pieces atleast in fewer places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understandable. If we were totally disregarding process then I'd definitely prefer this lives in conversations (conversations produces the assets, so it should also own the code publishing them).
But if its going to be a significant burden to put it there, I'm not that opposed to it being here.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@dibarbet : Is there an infra problem causing these test failures? I wouldn't expect these changes to fail the build. I could also use another review on this as well so I can close this out :) |
Yeah looks like there are some new flaky tests |
Have one question here - #8508 (comment) |
And responded : #8508 (comment) :) I'm happy to chat if you feel strongly though. |
/azp run dotnet.vscode-csharp |
Azure Pipelines successfully started running 1 pipeline(s). |
you should be able to just re-queue the individual job (either from the github checks page or AzDo page |
This pipeline ensures we get the latest roslyn copilot bits. IT needs to be approved explicitly from someone with a SAW, so I've left it as a manual trigger for now. I could imagine a release flow though that auto triggers some of these and that one person with a SAW makes all the approvals needed at once.
Pipeline is here: https://devdiv.visualstudio.com/DevDiv/_build?definitionId=27222